Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Pick List TypeError #35303

Merged
merged 1 commit into from
May 23, 2023
Merged

fix: Pick List TypeError #35303

merged 1 commit into from
May 23, 2023

Conversation

s-aga-r
Copy link
Contributor

@s-aga-r s-aga-r commented May 15, 2023

closes: #34761

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label May 15, 2023
@s-aga-r s-aga-r added dont-merge and removed needs-tests This PR needs automated unit-tests. labels May 15, 2023
@s-aga-r s-aga-r closed this May 17, 2023
@s-aga-r s-aga-r reopened this May 23, 2023
@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label May 23, 2023
@codecov
Copy link

codecov bot commented May 23, 2023 •
edited
Loading

Codecov Report

Merging #35303 (37766cc) into develop (00bb8ad) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 37766cc differs from pull request most recent head a111917. Consider uploading reports for the commit a111917 to get more accurate results

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop   #35303   +/-   ##
========================================
  Coverage    63.82%   63.82%           
========================================
  Files          813      813           
  Lines        60260    60213   -47     
========================================
- Hits         38462    38433   -29     
+ Misses       21798    21780   -18
Impacted Files Coverage Δ
erpnext/stock/doctype/pick_list/pick_list.py 81.09% <100.00%> (-0.19%) ⬇️

... and 7 files with indirect coverage changes

@s-aga-r s-aga-r added backport version-13-hotfix backport version-14-hotfix backport to version 14 and removed needs-tests This PR needs automated unit-tests. labels May 23, 2023
@s-aga-r s-aga-r marked this pull request as ready for review May 23, 2023 08:50
@s-aga-r s-aga-r merged commit 3940deb into frappe:develop May 23, 2023
This was referenced May 23, 2023
Merged
Merged
s-aga-r added a commit that referenced this pull request May 23, 2023
@s-aga-r
Merge pull request #35391 from frappe/mergify/bp/version-13-hotfix/pr…
97f9c0d 
…-35303

fix: Pick List TypeError (backport #35303)
s-aga-r added a commit that referenced this pull request May 23, 2023
@s-aga-r
Merge pull request #35390 from frappe/mergify/bp/version-14-hotfix/pr…
88ecc93 
…-35303

fix: Pick List TypeError (backport #35303)
@ankush ankush mentioned this pull request Oct 20, 2023
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rohitwaghchaure rohitwaghchaure Awaiting requested review from rohitwaghchaure rohitwaghchaure is a code owner

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Work Order Pick List - Error v14
1 participant
@s-aga-r